fix(LDAP): use displayname from DB, before reaching out to LDAP#59025
Merged
fix(LDAP): use displayname from DB, before reaching out to LDAP#59025
Conversation
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
blizzz
force-pushed
the
perf/noid/ldap-displayname-from-db
branch
from
a6d51d6 to
52bc492
Compare
As we do it with other information of the user, we now use the known value of a users displayname, and leave the updating to the background job. This improves performance of user facing actions where the display name is required and reduces queries to the LDAP server that are typically more expensive. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
perf/noid/ldap-displayname-from-db
branch
from
52bc492 to
badd759
Compare
Member
Author
|
/backport to stable31 |
provokateurin
approved these changes
Mar 18, 2026
miaulalala
reviewed
Mar 18, 2026
miaulalala
approved these changes
Mar 18, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/59025/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1c018957 0ace5473 badd759f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59025/stable31Error: Failed to push branch backport/59025/stable31: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As we do it with other information of the user, we now use the known value
of a users displayname, and leave the updating to the background job. This
improves performance of user facing actions where the display name is
required and reduces queries to the LDAP server that are typically more
expensive.
Checklist
3. to review, feature component)stable32)AI (if applicable)